Update babylon-support branch to use es6 imports, module-level GTLF loader function, auto-detect plugin extension, and add/remove observables #1397
+166
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georginahalpern
commented
Dec 11, 2025
georginahalpern
commented
- Update dependency to es6 and more recent babylon version
- Update imports to avoid import * from BABYLON
- Update gltfLoader to use module-level gltfloader ImportFileAsync (to enable treeshaking)
- Update gltfLoader to detect plugin extension vs hardcode glb
- Integrate babylon observables into add/remove event listeners
gkjohnson
reviewed
Dec 11, 2025
Contributor
gkjohnson
left a comment
gkjohnson
left a comment
There was a problem hiding this comment.
This is great, thanks! Just a few small changes and questions. I'll fix some of the lint errors in the other branch - looks like the CI only runs on PR into master.
| @@ -1,4 +1,4 @@ | |||
| import * as BABYLON from 'babylonjs'; | |||
| import { Scene, Engine, Vector3, ArcRotateCamera } from '@babylonjs'; | |||
Contributor
There was a problem hiding this comment.
Is this supposed to import from @babylonjs/core?
Comment on lines
+19
to
+41
| /** | ||
| * Detect if buffer contains GLB binary data by checking magic bytes | ||
| * @param {ArrayBuffer|Uint8Array} buffer - The file buffer | ||
| * @returns {boolean} True if GLB format | ||
| */ | ||
| isGLB( buffer ) { | ||
|
|
||
| // Handle both ArrayBuffer and typed arrays (e.g., Uint8Array) | ||
| const arrayBuffer = buffer instanceof ArrayBuffer ? buffer : buffer.buffer; | ||
| const byteOffset = buffer instanceof ArrayBuffer ? 0 : buffer.byteOffset; | ||
| const byteLength = buffer.byteLength; | ||
|
|
||
| if ( byteLength < 4 ) { | ||
|
|
||
| return false; | ||
|
|
||
| } | ||
|
|
||
| const view = new DataView( arrayBuffer, byteOffset, byteLength ); | ||
| const magic = view.getUint32( 0, true ); // little-endian | ||
| return magic === GLB_MAGIC; | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
Just to be sure: there's no way for Babylon to determine whether a file is a binary or ascii glTF automatically?
Comment on lines
-94
to
+95
| "babylonjs": "^7.0.0", | ||
| "babylonjs-loaders": "^7.0.0", | ||
| "@babylonjs/core": "^8.39.3", | ||
| "@babylonjs/loaders": "^8.39.3", |
Contributor
There was a problem hiding this comment.
Let's update the "peerDependencies" section, too. I'll let you decide which versions are needed for the current babylon support but >=8.0.0 seem reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.